Skip to content

allow showProgress=INTEGER to set progress bar update time#7259

Merged
ben-schwen merged 14 commits intomasterfrom
showProgress_update
Jan 8, 2026
Merged

allow showProgress=INTEGER to set progress bar update time#7259
ben-schwen merged 14 commits intomasterfrom
showProgress_update

Conversation

@ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Aug 21, 2025

Closes #6514

# simple example to trigger progress bar
f = function(x) {Sys.sleep(1); x}
dt = data.table(x = 1:10, y = 1:10)
dt[, f(x), y, showProgress=3L]

@codecov
Copy link

codecov bot commented Aug 21, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.99%. Comparing base (851467f) to head (ee671af).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7259      +/-   ##
==========================================
+ Coverage   98.96%   98.99%   +0.03%     
==========================================
  Files          87       87              
  Lines       16734    16729       -5     
==========================================
+ Hits        16560    16561       +1     
+ Misses        174      168       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Aug 21, 2025 •
edited
Loading

  • HEAD=showProgress_update stopped early for DT[by,verbose=TRUE] improved in #6296
    Comparison Plot

Generated via commit ee671af

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 2 minutes and 49 seconds
Installing different package versions 44 seconds
Running and plotting the test cases 4 minutes and 26 seconds

@tdhock
Copy link
Member

tdhock commented Aug 22, 2025

Thanks for the PR Ben. Is there a reason why the delay is integer rather than double/numeric? (which seems more natural for a time)

@ben-schwen
Copy link
Member Author

ben-schwen commented Aug 22, 2025 •
edited
Loading

Thanks for the PR Ben. Is there a reason why the delay is integer rather than double/numeric? (which seems more natural for a time)

I also thought about using doubles first, but then integer seemed like the right choice since everything below 1/4 second is hard to grasp so the granularity seems to be coarse enough and I also didn't want to cater for strange supplied values like NA (behaves like -INT_MAX), Inf, etc.

@ben-schwen ben-schwen marked this pull request as ready for review January 4, 2026 22:01
MichaelChirico
MichaelChirico reviewed Jan 8, 2026
View reviewed changes
MichaelChirico
MichaelChirico reviewed Jan 8, 2026
View reviewed changes
MichaelChirico
MichaelChirico reviewed Jan 8, 2026
View reviewed changes
MichaelChirico
MichaelChirico approved these changes Jan 8, 2026
View reviewed changes
Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge after the quick clean-ups requested. Thanks!

ben-schwen and others added 6 commits January 8, 2026 14:17
@ben-schwen @MichaelChirico
phrasing comment
6ec0a83 
Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
@ben-schwen @MichaelChirico
Update NEWS.md
f9b76f3 
Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
@ben-schwen
refine NEWS
fda47aa
@ben-schwen
update man
3579fb2
@ben-schwen
remove as.integer from signature
df8beab
@ben-schwen
remove unnecessary brackets
ee671af
@ben-schwen ben-schwen merged commit a54ee8d into master Jan 8, 2026
13 checks passed
@ben-schwen ben-schwen deleted the showProgress_update branch January 8, 2026 13:46
manmita pushed a commit to manmita/data.table that referenced this pull request Jan 8, 2026
@ben-schwen @MichaelChirico @manmita
allow showProgress=INTEGER to set progress bar update time (Rdatatabl…
7d6715a 
…e#7259)

* allow showProgress=INTEGER to set progress bar update time

* add NEWS

* cleanup merge

* refine NEWS

* make check more explicit

* adjust docs

* adjust nocov to what they really should cover

* phrasing comment

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* Update NEWS.md

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>

* refine NEWS

* update man

* remove as.integer from signature

* remove unnecessary brackets

---------

Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelChirico MichaelChirico MichaelChirico approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

group by showprogress too chatty

3 participants

@ben-schwen @tdhock @MichaelChirico